Run the linter as part of tests.

Fix lint warnings.

Run the linter as part of tests.
31ce8e9a · Niall Sheridan · c074b869 · 31ce8e9a · 31ce8e9a · 31ce8e9a
Commit 31ce8e9a authored Jun 13, 2016 by Niall Sheridan
--- a/.travis.yml
+++ b/.travis.yml
@@ -8,9 +8,13 @@ go:
  - 1.6.2
  - tip

+before_install:
+  - go get -v github.com/golang/lint/golint
+
 sudo: false
 script:
  - go build -v ./...
  - go list ./... |grep -v vendor/ |xargs go test
  - gofmt -d $(find -type f -name '*.go' -not -path './vendor/*')
  - go list ./... |grep -v vendor/ |xargs go vet
+  - go list ./... |grep -v vendor/ |xargs -L1 golint
--- a/server/auth/github/github.go
+++ b/server/auth/github/github.go
@@ -67,9 +67,9 @@ func (c *Config) Valid(token *oauth2.Token) bool {
 	return member
 }

-// GitHub doesn't seem to allow token revocation - tokens are indefinite and
-// there are no refresh options etc. Returns nil to satisfy the Provider
-// interface.
+// Revoke is a no-op revoke method. GitHub doesn't seem to allow token
+// revocation - tokens are indefinite and there are no refresh options etc.
+// Returns nil to satisfy the Provider interface.
 func (c *Config) Revoke(token *oauth2.Token) error {
 	return nil
 }


--- a/server/fs/s3.go
+++ b/server/fs/s3.go
@@ -19,6 +19,7 @@ import (
 	"github.com/nsheridan/cashier/server/config"
 )

+// Register the /s3/ filesystem as a well-known filesystem.
 func Register(config *config.AWS) {
 	ac := &aws.Config{}
 	// If region is unset the SDK will attempt to read the region from the environment.


--- a/templates/token.go
+++ b/templates/token.go
 package templates

+// Token is the page users see when authenticated.
 const Token = `<html>
  <head>
    <title>YOUR TOKEN!</title>